Support Infinite Geocoders, Support Offline Geocoder #28
Conversation
miles-grant-ibigroup
assigned daniel-heppner-ibigroup and unassigned miles-grant-ibigroup
env.example.yml
Outdated
|
|
||
| REDIS_HOST: (optional) <insert IP of redis host here> | ||
| REDIS_KEY: (optional) <insert redis password here> | ||
| GEOCODERS: <JSON Array of OTP-UI `GeocoderConfig`s> |
There was a problem hiding this comment.
How can this be a JSON array?
There was a problem hiding this comment.
It's stringified!
There was a problem hiding this comment.
Okay. Can you just tweak:
| GEOCODERS: <JSON Array of OTP-UI `GeocoderConfig`s> | |
| GEOCODERS: <Stringified JSON Array of OTP-UI `GeocoderConfig`s> |
env.example.yml
Outdated
| REDIS_HOST: (optional) <insert IP of redis host here> | ||
| REDIS_KEY: (optional) <insert redis password here> | ||
| GEOCODERS: <JSON Array of OTP-UI `GeocoderConfig`s> | ||
| BACKUP_GEOCODERS: <JSON Array of OTP-UI `GeocoderConfig`s. Same length as GEOCODERS> |
There was a problem hiding this comment.
Are backup geocoders supposed to be in the same order as the main ones? Is each backup geocoder at a given index supposed to be of the same kind as the main one? If so, would it make sense to write something like:
GEOCODERS:
- main:
...
backup:
...
- main:
...
There was a problem hiding this comment.
That would make sense but we're dealing with serverless which loads all these in as env variables. Doing what you suggest is technically possible but would be a huge overhead to implement
There was a problem hiding this comment.
Same thing, just tweak the comment:
| BACKUP_GEOCODERS: <JSON Array of OTP-UI `GeocoderConfig`s. Same length as GEOCODERS> | |
| BACKUP_GEOCODERS: <Stringified JSON Array of OTP-UI `GeocoderConfig`s. Same length and order as GEOCODERS> |
env.example.yml
Outdated
|
|
||
| REDIS_HOST: (optional) <insert IP of redis host here> | ||
| REDIS_KEY: (optional) <insert redis password here> | ||
| GEOCODERS: <JSON Array of OTP-UI `GeocoderConfig`s> |
There was a problem hiding this comment.
Okay. Can you just tweak:
| GEOCODERS: <JSON Array of OTP-UI `GeocoderConfig`s> | |
| GEOCODERS: <Stringified JSON Array of OTP-UI `GeocoderConfig`s> |
env.example.yml
Outdated
| REDIS_HOST: (optional) <insert IP of redis host here> | ||
| REDIS_KEY: (optional) <insert redis password here> | ||
| GEOCODERS: <JSON Array of OTP-UI `GeocoderConfig`s> | ||
| BACKUP_GEOCODERS: <JSON Array of OTP-UI `GeocoderConfig`s. Same length as GEOCODERS> |
There was a problem hiding this comment.
Same thing, just tweak the comment:
| BACKUP_GEOCODERS: <JSON Array of OTP-UI `GeocoderConfig`s. Same length as GEOCODERS> | |
| BACKUP_GEOCODERS: <Stringified JSON Array of OTP-UI `GeocoderConfig`s. Same length and order as GEOCODERS> |
|
Great suggestions thanks! |
miles-grant-ibigroup
assigned daniel-heppner-ibigroup and unassigned miles-grant-ibigroup
daniel-heppner-ibigroup
assigned miles-grant-ibigroup and unassigned daniel-heppner-ibigroup
Updates to latest geocoder package, introduces breaking change that allows for UNLIMITED GEOCODERS
When deploying, be sure to disable api gateway caching. It's not longer compatible